feat: add C implementation for stats/base/dists/lognormal/logcdf#10882
Open
rautelaKamal wants to merge 1 commit intostdlib-js:developfrom
Open
feat: add C implementation for stats/base/dists/lognormal/logcdf#10882rautelaKamal wants to merge 1 commit intostdlib-js:developfrom
rautelaKamal wants to merge 1 commit intostdlib-js:developfrom
Conversation
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
rautelaKamal
force-pushed
the
feat/stats/base/dists/lognormal/logcdf-c-port
branch
3 times, most recently
from
960fd26 to
36f518d
Compare
rautelaKamal
force-pushed
the
feat/stats/base/dists/lognormal/logcdf-c-port
branch
from
36f518d to
6ecc2de
Compare
rautelaKamal
force-pushed
the
feat/stats/base/dists/lognormal/logcdf-c-port
branch
from
6ecc2de to
e454f06
Compare
rautelaKamal
force-pushed
the
feat/stats/base/dists/lognormal/logcdf-c-port
branch
from
e454f06 to
14489bd
Compare
kgryte
reviewed
Apr 12, 2026
Member
There was a problem hiding this comment.
@rautelaKamal You need to revert many of the changes made to this file.
kgryte
reviewed
Apr 12, 2026
| } else { | ||
| delta = abs( y - expected[ i ] ); | ||
| tol = 1500.0 * EPS * abs( expected[ i ] ); | ||
| t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. sigma: '+sigma[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); |
Member
There was a problem hiding this comment.
We should go ahead and migrate to using isAlmostSameValue for ULP-based testing.
Contributor
Author
There was a problem hiding this comment.
I've migrated the tests to use isAlmostSameValue for ULP-based testing in the latest push. This PR should be ready for re-review.
kgryte
changed the title
stats/base/dists/lognormal/logcdf
kgryte
added
difficulty: 2
rautelaKamal
force-pushed
the
feat/stats/base/dists/lognormal/logcdf-c-port
branch
from
14489bd to
e705513
Compare
rautelaKamal
changed the title
stats/base/dists/lognormal/logcdf
rautelaKamal
force-pushed
the
feat/stats/base/dists/lognormal/logcdf-c-port
branch
from
e705513 to
635e533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this pull request?
This pull request:
@stdlib/stats/base/dists/lognormal/logcdf). Following the pattern of the JS version, the C logic log-transforms the inputxand elegantly delegates to the existing C implementation of@stdlib/stats/base/dists/normal/logcdf.Related Issues
Does this pull request have any related issues?
This pull request has the following related issues:
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
AI Assistance Disclosure
If yes, how was AI used?
I used an AI coding assistant to help generate the C native addon boilerplate, manifest files, and safely mirror the JS test logic/R fixtures into the native test files. I manually reviewed all outputs and verified compilation.
Checklist